spring-projects / spring-projects/spring-data-rest

StackOverflowError when requesting Json Schema for profile when entity contains member of same type [DATAREST-1282]

Open
#1,643 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Tony Harrison opened DATAREST-1282 and commented

When and entity contains a member variable of the same type/class requesting the json-schema of the profile results in StackOverflowError

 

eg:

@Value
@Builder
public class Item {
    private String name;
    private Item child;
}

 

@RepositoryRestResource
public interface ItemRestRepository extends Repository<Item, String>, QueryByExampleExecutor<Item> {
    Page<Item> findAll(Pageable var1);
    Optional<Item> findById(String var1);
}
curl -H "Accept: application/schema+json" http://localhost:8080/profile/items
java.lang.StackOverflowError: nulljava.lang.StackOverflowError: null at com.fasterxml.jackson.databind.introspect.AnnotatedFieldCollector._findFields(AnnotatedFieldCollector.java:58) ~[jackson-databind-2.9.6.jar:2.9.6] at com.fasterxml.jackson.databind.introspect.AnnotatedFieldCollector._findFields(AnnotatedFieldCollector.java:64) ~[jackson-databind-2.9.6.jar:2.9.6] at com.fasterxml.jackson.databind.introspect.AnnotatedFieldCollector.collect(AnnotatedFieldCollector.java:41) ~[jackson-databind-2.9.6.jar:2.9.6] at com.fasterxml.jackson.databind.introspect.AnnotatedFieldCollector.collectFields(AnnotatedFieldCollector.java:36) ~[jackson-databind-2.9.6.jar:2.9.6] at com.fasterxml.jackson.databind.introspect.AnnotatedClass._fields(AnnotatedClass.java:349) ~[jackson-databind-2.9.6.jar:2.9.6] at com.fasterxml.jackson.databind.introspect.AnnotatedClass.fields(AnnotatedClass.java:321) ~[jackson-databind-2.9.6.jar:2.9.6] at com.fasterxml.jackson.databind.introspect.POJOPropertiesCollector._addFields(POJOPropertiesCollector.java:379) ~[jackson-databind-2.9.6.jar:2.9.6] at com.fasterxml.jackson.databind.introspect.POJOPropertiesCollector.collectAll(POJOPropertiesCollector.java:308) ~[jackson-databind-2.9.6.jar:2.9.6] at com.fasterxml.jackson.databind.introspect.POJOPropertiesCollector.getPropertyMap(POJOPropertiesCollector.java:287) ~[jackson-databind-2.9.6.jar:2.9.6] at com.fasterxml.jackson.databind.introspect.POJOPropertiesCollector.getProperties(POJOPropertiesCollector.java:170) ~[jackson-databind-2.9.6.jar:2.9.6] at com.fasterxml.jackson.databind.introspect.BasicBeanDescription._properties(BasicBeanDescription.java:164) ~[jackson-databind-2.9.6.jar:2.9.6] at com.fasterxml.jackson.databind.introspect.BasicBeanDescription.findProperties(BasicBeanDescription.java:239) ~[jackson-databind-2.9.6.jar:2.9.6] at org.springframework.data.rest.webmvc.json.JacksonMetadata.<init>(JacksonMetadata.java:71) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.lambda$getPropertiesFor$4(PersistentEntityToJsonSchemaConverter.java:173) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at java.util.Optional.map(Optional.java:215) ~[na:1.8.0_131] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.getPropertiesFor(PersistentEntityToJsonSchemaConverter.java:171) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.getNestedPropertiesFor(PersistentEntityToJsonSchemaConverter.java:275) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.lambda$null$2(PersistentEntityToJsonSchemaConverter.java:248) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at java.util.Optional.ifPresent(Optional.java:159) ~[na:1.8.0_131] at org.springframework.data.util.Optionals.ifPresentOrElse(Optionals.java:208) ~[spring-data-commons-2.0.9.RELEASE.jar:2.0.9.RELEASE] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.lambda$getPropertiesFor$4(PersistentEntityToJsonSchemaConverter.java:236) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at java.util.Optional.map(Optional.java:215) ~[na:1.8.0_131] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.getPropertiesFor(PersistentEntityToJsonSchemaConverter.java:171) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.getNestedPropertiesFor(PersistentEntityToJsonSchemaConverter.java:275) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.lambda$null$2(PersistentEntityToJsonSchemaConverter.java:248) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at java.util.Optional.ifPresent(Optional.java:159) ~[na:1.8.0_131] at org.springframework.data.util.Optionals.ifPresentOrElse(Optionals.java:208) ~[spring-data-commons-2.0.9.RELEASE.jar:2.0.9.RELEASE] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.lambda$getPropertiesFor$4(PersistentEntityToJsonSchemaConverter.java:236) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at java.util.Optional.map(Optional.java:215) ~[na:1.8.0_131] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.getPropertiesFor(PersistentEntityToJsonSchemaConverter.java:171) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.getNestedPropertiesFor(PersistentEntityToJsonSchemaConverter.java:275) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.lambda$null$2(PersistentEntityToJsonSchemaConverter.java:248) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at java.util.Optional.ifPresent(Optional.java:159) ~[na:1.8.0_131] at org.springframework.data.util.Optionals.ifPresentOrElse(Optionals.java:208) ~[spring-data-commons-2.0.9.RELEASE.jar:2.0.9.RELEASE] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.lambda$getPropertiesFor$4(PersistentEntityToJsonSchemaConverter.java:236) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at java.util.Optional.map(Optional.java:215) ~[na:1.8.0_131] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.getPropertiesFor(PersistentEntityToJsonSchemaConverter.java:171) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.getNestedPropertiesFor(PersistentEntityToJsonSchemaConverter.java:275) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE] at org.springframework.data.rest.webmvc.json.PersistentEntityToJsonSchemaConverter.lambda$null$2(PersistentEntityToJsonSchemaConverter.java:248) ~[spring-data-rest-webmvc-3.0.9.RELEASE.jar:3.0.9.RELEASE]

 

 

 


Affects: 3.0.9 (Kay SR9)

Attachments:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.