spring-projects / spring-projects/spring-data-rest
SortTranslator ignores snake-cased properties [DATAREST-1276]
@odrotbohm is already working on this.
Since Dec 31, 2020.
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
Édouard Hue opened DATAREST-1276 and commented
Given a @Document annotated class with the following attribute, and an according @RepositoryRestResource:
@Field
@JsonProperty("cooking_duration")
private Duration cookingDuration;
When issuing a GET request with ?sort=cooking_duration, the org.springframework.data.rest.webmvc.json.JacksonMappingAwareSortTranslator won't translate cooking_duration to cookingDuration and no sorting is performed.
When changing @JsonProperty("cooking_duration") to @JsonProperty("cooking-duration"), and doing a ?sort=cooking-duration request, JacksonMappingAwareSortTranslator properly resolves the property name.
It looks like org.springframework.data.rest.webmvc.json.JacksonMappingAwareSortTranslator.SortTranslator#SPLITTER is used to split the property name with _ and .. I can see the case for splitting on . for nested properties paths, but why would you split on underscores?
No further details from DATAREST-1276
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.