spring-projects / spring-projects/spring-data-rest

HAL browser does not show NON-GET editor for not yet associated links [DATAREST-1242]

Open
#1,601 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Roger Villars opened DATAREST-1242 and commented

When trying to call a NON-GET request for an not yet associated link (e.g. a reference to another entity) no editor will be opened, and a 404 will be logged to the browser console.

The reason is that both the HEAD call and the GET call in CustomPostForm.js will fail but the try/catch (that would load the fallback editor) is not working because $.ajax() does not throw any errors. An appropriate error callback function needs to be provided instead.

This breaks the possibility to set an uri-list for this link with the HAL browser


Affects: 3.0.6 (Kay SR6)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.