spring-projects / spring-projects/spring-data-rest

Missing Etag header using custom @RepositoryRestController [DATAREST-1201]

Open
#1,562 5 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

status: feedback-provided type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Daniele Renda opened DATAREST-1201 and commented

I'm using Spring Boot 1.5.10, Spring Data REST, Spring HEATEOAS, Spring HPA. I created a custom GET method in my @RepositoryRestController like this:

@GetMapping(path = "/users/{id}")
    public ResponseEntity<?> findById(@PathVariable(value = "id") long userId, Locale locale,
            PersistentEntityResourceAssembler resourceAssembler) {
        Authentication auth = SecurityContextHolder.getContext().getAuthentication();
        //My implementation

        return new ResponseEntity<>(resourceAssembler.toResource(user), HttpStatus.OK);
    }

Unfortunately, differently from the default Spring Data REST repository the Etag header is missing.

Am I missing something? Is this behaviour desired?


Affects: 3.0.3 (Kay SR3)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.