spring-projects / spring-projects/spring-data-rest

Projection does not affect SQL [DATAREST-1171]

Open
#1,537 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: enhancement
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Sam Kruglov opened DATAREST-1171 and commented

I define a User with firstName and SecondName and a projection FirstNameOnly.
I create a UserRepository and inside that define a query method ```
FirstNameOnly findFirstNameById(@Param("id") Long id);

Now, there are two ways I can access it:
1. localhost:8080/users/1?projection=FirstNameOnly
1. localhost:8080/users/search/findFirstNameById?id=1

First approach produces valid JSON, but SQL query actually selects all of the fields anyway.
The second approach produces valid JSON and valid SQL query (only selects the "firstName" column).

I would really prefer the first approach to also generate valid SQL. What do you think?

Affects: 2.6.9 (Ingalls SR9)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.