spring-projects / spring-projects/spring-data-rest
Regression of DATAREST-792: PUT request for item resource with customized entity lookup fails [DATAREST-1146]
Open
@odrotbohm is already working on this.
Since Dec 31, 2020.
in: repository
type: bug
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
Chris Wells opened DATAREST-1146 and commented
There appears to be a regression of DATAREST-792 in v3.0.0. It works when I use Spring Boot 1.5.8.BUILD-SNAPSHOT, which uses 2.6.7.RELEASE. It fails with Spring Boot 2.0.0.BUILD-SNAPSHOT, which uses 3.0.0.RELEASE.
Simple example code:
@Component
public class RepositoryRestConfig extends RepositoryRestConfigurerAdapter {
@Override
public void configureRepositoryRestConfiguration(RepositoryRestConfiguration config) {
config.withEntityLookup()
.forRepository(PersonRepository.class)
.withIdMapping(Person::getName)
.withLookup(PersonRepository::findOneByName);
}
}
@RepositoryRestResource
public interface PersonRepository extends PagingAndSortingRepository<Person, Integer> {
@RestResource(exported = false)
Optional<Person> findOneByName(String name);
}
Affects: 3.0 GA (Kay)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.