spring-projects / spring-projects/spring-data-rest
the defaut value mentionned for RepositoryRestConfiguration$getLimitParamName is incorrect [DATAREST-1145]
@odrotbohm is already working on this.
Since Dec 31, 2020.
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
Marc Tarin opened DATAREST-1145 and commented
The javadoc of org.springframework.data.rest.core.config.RepositoryRestConfiguration$getLimitParamName() states that ??Default is 'limit'?? which while consistent with limitParamName variable name, is false (limitParamName is initialized to 'page').
Beyond simply fixing the javadoc, I would also suggest, for the sake of consistency with pageParamName and sortParamName, that limitParamName should be renamed to sizeParamName (same goes for the getter and setter, obviously)
Affects: 2.5.11 (Hopper SR11), 2.6.7 (Ingalls SR7), 3.0 GA (Kay)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.