spring-projects / spring-projects/spring-data-rest

Template parameters missing in self link in pagination links [DATAREST-1117]

Open
#1,478 3 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Richard Schoch opened DATAREST-1117 and commented

According to this doc the self link should include the template parameters page, size and sort on the whole collection.

In our project this doesn't seem to be working correctly. See attached screenshots.

On an side note I would like to ask why the self link shows the whole collection in the first place. Shouldnt it show the current page with page and size parameters in the href?

We are using the Spring boot starter data rest version 1.5.4


Attachments:

1 votes, 4 watchers

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.