spring-projects / spring-projects/spring-data-rest

Sorting does not work for camelCase properties [DATAREST-1101]

Open
#1,464 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Jorge Cara opened DATAREST-1101 and commented

We are unable to sort by a field with a composed name.

  • field name example: private Date creationDate
  • request example: /entities?sort=creation_date,desc
  • we have the following property to transform camel case to snake case on jackson: spring.jackson.property-naming-strategy=CAMEL_CASE_TO_LOWER_CASE_WITH_UNDERSCORES

We have also found out that on org.springframework.data.rest.webmvc.json.JacksonMappingAwareSortTranslator method public Sort translateSort(Sort input, PersistentEntity<?, ?> rootEntity) parameters are splitted by '_' treating 'creation' and 'date' as different properties that cannot be mapped to the original field


Affects: 2.6.4 (Ingalls SR4)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.