spring-projects / spring-projects/spring-data-rest

JpaHelper hard codes the OpenEntityManagerInViewInterceptor class making replacement necessary when using a different interceptor [DATAREST-1037]

Open
#1,392 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: task
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Ezra Epstein opened DATAREST-1037 and commented

Spring boot supports overriding of the default OpenEntityManagerInViewInterceptor by defining a @Bean with that type. But this is ignored by the JpaHelper.

A simple enhancement to the JpaHelper that takes a class/type for the OpenEntityManagerInViewInterceptor to create would make the JpaHelper extensible and configurable rather than needing to replace it when using a customer OpenEntityManagerInViewInterceptor


Affects: 2.5.8 (Hopper SR8)

Reference URL: https://github.com/spring-projects/spring-data-rest/blob/master/spring-data-rest-webmvc/src/main/java/org/springframework/data/rest/webmvc/support/JpaHelper.java

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.