spring-projects / spring-projects/spring-data-rest
Version of jackson-annotations [DATAREST-1026]
@odrotbohm is already working on this.
Since Dec 31, 2020.
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
Sud Ramasamy opened DATAREST-1026 and commented
The spring-data-rest poms (webmvc among others) lists a dependency on jackson-annotations as ${jackson.version} which therefore brings in version 2.8.6 of jackson-annotations.
This seems a little more agressive than the Jackson BOM itself. Please refer to the Jackson 2.8.6 BOM here: https://github.com/FasterXML/jackson-bom/blob/jackson-bom-2.8.6/pom.xml
The jackson-annotations version is 2.8.0.
Is there a clear need for jackson-annotations 2.8.6 or can Spring Data Rest change to use the version determined by the Jackson BOM.
The reason we ran into an issue with the newer version of jackson-annotation being pulled in by Spring Data Rest was because we are using Maven's upper version dependency check to ensure we are packaging the expected versions of the libraries. We can certainly tweak our build to accommodate what Spring Data Rest maybe configured for. But I wanted to log this in case it made sense to make the change in Spring Data Rest.
Affects: 2.6.1 (Ingalls SR1)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.