spring-projects / spring-projects/spring-data-rest

Persistent Entity Collection Mapping Issue in DomainObjectReader [DATAREST-1009]

Open
#1,372 1 comment 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Cole Olejniczak opened DATAREST-1009 and commented

Attempting to modify a persistent entity that has a collection of persistent entities fails if the collection is empty.

@Entity
public class Person {
    private List<Pet> pets;
}
@Entity
public class Pet {
    private String name;
}

If DomainObjectMapper tries to read { "pets" : ["pets/1"] } into a Person with no pets, it will fail. If it tries to read the same into a Person with at least 1 Pet, it will succeed.

DomainObjectMapper tries to readTreeValue the given json if the collection is empty and fails.


Affects: 2.5.7 (Hopper SR7)

Attachments:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.