spring-projects / spring-projects/spring-data-rest

Internal ObjectMapper shouldn't be exposed as Spring bean [DATAREST-981]

Open
#1,348 9 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

status: feedback-provided type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Stéphane Nicoll opened DATAREST-981 and commented

RepositoryRestMvcConfiguration exposes two internal ObjectMapper beans. This has quite a nasty side effect in Spring Boot but regardless, I don't think that "internal object mapper" should be exposed in the context. If you need to pass that around, you can have a custom type of yours exposed as a bean that provides access to the required object mapper


Affects: 2.6 RC1 (Ingalls)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.