spring-projects / spring-projects/spring-data-rest

infinite recursion when Validator do rejectValue [DATAREST-949]

Open
#1,319 1 comment 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

benkuly opened DATAREST-949 and commented

When a Validator for a Spring Data REST Event do rejectValues(fieldName, errorCode) on the Errors Object and the fieldName is associated to an Entity with many relations, you can get an infinite recursion, because Jackson seems to try to render the "invalidValue" he usually returns as Json-Error-Response.

Example:
Two Classes: Treasure, User
Treasure has an Name and an Owner and User a Set of Treasure (that´s the cycle).
When I now try to PUT { "name": "test", "owner":"https://localhost:8443/api/user/2" } on an existing Treasure and the Validator do errors.rejectValues("owner", "error.wrongRole") the problem occures


Affects: 2.5.5 (Hopper SR5)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.