DomainObjectReader removes unwrapped properties [DATAREST-912]

Jan Van Rensbergen opened DATAREST-912 and commented

When using the jackson @JsonUnwrapped annotation the doMerge method on the DomainObjectReader will remove the JsonNode from the iterator before the ObjectReader reads from the RootNode.

private <T> T doMerge(ObjectNode root, T target, ObjectMapper mapper) throws Exception {
               ...
		for (Iterator<Entry<String, JsonNode>> i = root.fields(); i.hasNext();) {

			Entry<String, JsonNode> entry = i.next();
			JsonNode child = entry.getValue();

			if (child.isArray()) {
				continue;
			}

			String fieldName = entry.getKey();

			if (!mappedProperties.hasPersistentPropertyForField(fieldName)) {
				i.remove(); //<-- this will remove my unwrapped properties
				continue;
			}
                ...
		return mapper.readerForUpdating(target).readValue(root);
	}

When objects uses @Unwrapped in a collection this problem does not occur because Array child nodes are skipped.

Issue Links:

• DATAREST-910 Support nested Sort properties

1 votes, 3 watchers