spring-projects / spring-projects/spring-data-rest

PreAuthorize annotation not applied for PATCH request [DATAREST-877]

Open
#1,247 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

in: repository type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Raghavendra Chary B opened DATAREST-877 and commented

We are using spring data rest, with spring security applied on repository, like below:

@PreAuthorize("hasRole('ROLE_ADMIN')")
Order save(@P("order") Order order);

In case of POST and PUT, PreAuthorize is working as expected i.e it doesnt change values in database and gives 403 for non-admin user.

In case of PATCH request, it changes value in database and gives 403. Would like to know why PreAuthorize not applied in case of PATCH.


Affects: 2.2.4 (Evans SR4)

Reference URL: http://stackoverflow.com/questions/39053117/spring-data-rest-preauthorize-annotation-not-applied-for-patch-request

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.