spring-projects / spring-projects/spring-data-rest
Use a less generic name for ObjectMapper bean created by RepositoryRestMvcConfiguration [DATAREST-834]
@odrotbohm is already working on this.
Since Dec 31, 2020.
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
Andy Wilkinson opened DATAREST-834 and commented
The bean is currently called objectMapper which is a rather generic name for a bean that is described as "The Jackson ObjectMapper used internally". Could it be called something like dataRestObjectMapper instead? This would make it less likely to accidentally override a user's own ObjectMapper definition and would also hopefully reduce the chance of autowiring working unexpectedly due to the bean name matching the name of the target method argument
Affects: 2.4.4 (Gosling SR4)
Reference URL: https://github.com/spring-projects/spring-boot/issues/5984
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.