spring-projects / spring-projects/spring-data-rest

Global Validation Errors are lost in RepositoryConstraintViolationExceptionMessage [DATAREST-832]

Open
#1,205 2 comments 1 reaction 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

in: repository type: bug
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Pablo Andrés Grisafi opened DATAREST-832 and commented

RepositoryConstraintViolationExceptionMessage only uses field errors to create violation errors
From the constructor:

for (FieldError fieldError : violationException.getErrors().getFieldErrors()) {

So global errors (the one you add with errors.reject instead of errors.rejectValue or ValidationUtils.rejectIf) are not mapped to ValidationError's, and do not show in json response

Or am I doing something wrong?


Affects: 2.5.1 (Hopper SR1)

6 votes, 8 watchers

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.