Repositories inaccurately detected when multiple interfaces exist for domain type [DATAREST-917]

Christopher Smith opened DATAREST-917 and commented

In attempts to deal with the security problem, I ended up defining multiple Spring Data repository interfaces for some domain classes. While these repositories all get injected correctly into their consumers, Spring Data REST erratically fails to register certain domain types.

On debugging, I found that RepositoryDetectionStrategy#isExported seems to be called once per domain class, not per repository, so if my @RepositoryRestResource happens to be scanned first, then it gets registered; if not, the annotated interface is never submitted to the detection strategy at all.

This appears to be because RepositoryResourceMappings#populateCache is using the domain type as a map key and not filtering ineligible repositories before causing map collisions

Affects: 2.5.4 (Hopper SR4)

1 votes, 2 watchers