spring-projects / spring-projects/spring-data-rest

Why DELETE method exported only with findOne [DATAREST-825]

Open
#1,130 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

type: enhancement
Dominant language
Java
Stars
958
Forks
568
PR merge metrics
No merged PRs in 30d

Description

Pavel varchenko opened DATAREST-825 and commented

As we can see in

Set<HttpMethod> getMethodsFor(ResourceType type);

method of

org.springframework.data.rest.core.mapping.CrudMethodsSupportedHttpMethods

DELETE method will be added only if exposesDelete and exposesFindOne

if (exposedMethods.exposesDelete() && exposedMethods.exposesFindOne()) {
 methods.add(DELETE);
}

Why this implemented like this? In our architecture we wouldn't like to export findOne method. But if we try to export only delete method it does not work because of subject

@Override
@RestResource
void delete(UUID id);

Affects: 2.5.1 (Hopper SR1)

Referenced from: commits https://github.com/spring-projects/spring-data-rest/commit/f2f9564882a7ec5e92804a50056cd600312924a3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.