spring-projects / spring-projects/spring-data-rest
Add Ordered to AbstractRepositoryEventListener [DATAREST-685]
@odrotbohm is already working on this.
Since Dec 31, 2020.
- Dominant language
- Java
- Stars
- 958
- Forks
- 568
- PR merge metrics
- No merged PRs in 30d
Description
Ilya Novoseltsev opened DATAREST-685 and commented
Spring ApplicationEvent listeners can be ordered. Currently ValidatingRepositoryEventListener has no order and is executed with lowest priority, that is, last.
This is bad - custom event listeners cannot be configured to run after validation and must handle potentially invalid data themselves.
I propose adding implements Ordered to AbstractRepositoryEventListener with order = 0. That will allow users to place their custom listeners before and after internal Spring Rest listeners.
As a bonus, the order of ValidatingRepositoryEventListener can be made configurable via RepositoryRestConfigurerAdapter
Affects: 2.4 GA (Gosling)
2 votes, 4 watchers
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.