spring-projects / spring-projects/spring-data-rest

Unnecessary objects creation in RepositoryRestExceptionHandler class [DATAREST-641]

Open
#1,019 4 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 31, 2020.

status: feedback-provided type: enhancement
Dominant language
Java
Stars
958
Forks
568
No merged PRs in 30d

Description

Oleksandr Vengrovskiy opened DATAREST-641 and commented

Almost all implementations of package-private RepositoryRestExceptionHandler class methods require a creation of a new object of HttpHeaders class. This new object creation per method call is seems to be unnecessary.

For example it can be solved by creating a private static final variable, which will be used in further methods calls

Affects: 2.4 RC1 (Gosling)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.