spring-projects / spring-projects/spring-data-relational

Support Criteria with SqlIdentifier (supporting "quoted" column names)

Open
#940 6 comments 0 reactions 1 assignee View on GitHub

@schauder is already working on this.

Since Jul 21, 2021.

in: selectbuilder type: enhancement
Dominant language
Java
Stars
827
Forks
394
No merged PRs in 30d

Description

Hi,

Currently, Criteria only supports "unquoted" SqlIdentifiers - this occurs because the API only accepts a String and then passes it on to SqlIdentifier.unquoted().

I have a use-case where I would like to reuse the Criteria API but need to construct SqlIdentifier (I need support for quoted and composite). This would enable to better compose a custom add-on on top of the R2DBC repositories as I would be able to reuse the same Criteria class for filtering (rather than having to "invent my own").

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.