spring-projects / spring-projects/spring-data-relational
Use JSR 310 converters instead of ObjectToObject converters
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 827
- Forks
- 394
- PR merge metrics
- No merged PRs in 30d
Description
Currently we are using Spring Frameworks ObjectToObject converters for some date conversions, which uses a lot of reflection. This could be improved on when we use our dedicated JSR 310 converters, which unfortunately doesn't seem to be straight forward.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/Jsr310TimestampBasedConverters.java at line 58, then trace where the Spring Framework ObjectToObject converters handle date conversions. Compare the existing JSR 310 converter path and verify that the affected conversions use the dedicated converters instead of reflection.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- database
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100