spring-projects / spring-projects/spring-data-relational
Refactor Identifier construction
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 827
- Forks
- 394
- PR merge metrics
- No merged PRs in 30d
Description
The construction of the identifier used to query nested collections is not well encapsulated.
This is especially obvious when constructing the identifier for deeply nested collections without ids.
It currently relies for Lists on the row number of the ResultSet although it really should work just as for Maps.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source files, tests, or entry points are named. Trace identifier construction for nested collections, comparing the List path with the Map path and checking deeply nested collections without ids. Done means identifier construction is encapsulated and List handling no longer depends on the ResultSet row number.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- database
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100