spring-projects / spring-projects/spring-data-relational
Cleanup `SqlParametersFactory`
Open
Nobody has claimed this yet.
type: task
- Dominant language
- Java
- Stars
- 827
- Forks
- 394
- PR merge metrics
- No merged PRs in 30d
Description
addConvertedPropertyValuesAsList interacts with the converter multiple times to write a JDBC value for each collection entry. Ideally, we move these calls into JdbcConverter to improve locality and have an improved cohesion across the involved components.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading SqlParametersFactory and its addConvertedPropertyValuesAsList method, then inspect JdbcConverter to understand the existing conversion calls. The work is complete when collection-entry JDBC value conversion is handled in JdbcConverter without changing the resulting values or behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend, database
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100