spring-projects / spring-projects/spring-data-redis

Refactor Converters to allow better code reuse. [DATAREDIS-404]

Open
#979 0 comments 0 reactions 1 assignee View on GitHub

@christophstrobl is already working on this.

Since Dec 30, 2020.

in: core type: task
Dominant language
Java
Stars
1.9k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

Christoph Strobl opened DATAREDIS-404 and commented

Currently we've got different converter implementation for the redis drivers we support. Though some of the features used in the converters could be reused (like. converting boundaries for zrange commands). This is unfortunately limited by a lot of static instantiation within the specific converters.

So it would make sense so split the actual converter implementations into different classes allowing to extract a common set of functionality


No further details from DATAREDIS-404

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.