spring-projects / spring-projects/spring-data-redis
connectionProvider.release() doesn't really discard the connection after connection invalidated.
Open
@mp911de is already working on this.
Since Dec 16, 2024.
type: enhancement
- Dominant language
- Java
- Stars
- 1.9k
- Forks
- 1.3k
- PR merge metrics
- No merged PRs in 30d
Description
Inside validateConnection, called resetConnection(), and then called release(), but the action of release() does not necessarily discard the connection.
So, getNativeConnection() probably get a same channel(TCP) which is invalid.
We've actually tested this, and the result is that still get the same tcp connection after resetConnection many times.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.