spring-projects / spring-projects/spring-data-redis

MappingRedisConverter deserializes collections as nulls if it is empty

Open
#2,298 1 comment 0 reactions 1 assignee View on GitHub

@christophstrobl is already working on this.

Since Apr 11, 2022.

status: waiting-for-triage
Dominant language
Java
Stars
1.9k
Forks
1.3k
No merged PRs in 30d

Description

Method readCollectionOrArray creates a collection, although if there are no keys it returns null, which seems kinda strange. Wouldn't it be more client-friendly to return an empty list?
For example:


@RedisHash("Entity")
public class Entity {
    @Id
    private long id;

    @Indexed
    private List<String> props;
}

props will be null on query if it was saved as an empty list

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.