spring-projects / spring-projects/spring-data-mongodb

QueryMapper does not support $function while converting _id

Open
#4,812 3 comments 0 reactions 1 assignee View on GitHub

@christophstrobl is already working on this.

Since Oct 21, 2024.

status: pending-design-work type: bug
Dominant language
Java
Stars
1.7k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Suppose you have a document where _id is defined with a $function, like the following:

{
  "_id": {
    "$function": {
      "body": "some js code that takes no arguments"
      "args": []
      "lang": "js"
    }
  }
}

When invoking QueryMapper#getMappedObject (e.g. when building an aggregation pipeline), given that documentField.isIdField() is true, QueryMapper tries to convert every field of the subdocument to an ObjectId. Strings (that are not valid ObjectIds) are left untouched, but an empty array is converted to null, resulting in:

{
  "_id": {
    "$function": {
      "body": "some js code that takes no arguments"
      "args": null
      "lang": "js"
    }
  }
}

Sending this to mongodb will result in an exception since args is required and must be an array.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.