spring-projects / spring-projects/spring-data-mongodb

How about adding validation to MongoCustomConversions class constructor

Open
#4,544 0 comments 0 reactions 1 assignee View on GitHub

@christophstrobl is already working on this.

Since Nov 2, 2023.

status: waiting-for-triage
Dominant language
Java
Stars
1.7k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

First, thank you for supporting spring framework.

I encounter this converter issue while i developing with spring & mongodb. Also, we have solution to avoid above issue, but there seems to be a hole that can create problems(unexpected behavior to service developers)

So, how about validation (at least add warning) to Converter<String, Enum> without ReadingConverter annotation? If it is okay, can i try on this issue? 😄

Please review positively! have a nice day

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.