spring-projects / spring-projects/spring-data-mongodb

Remove assertions on hot code paths for methods considered internal API.

Open
#4,066 0 comments 0 reactions 1 assignee View on GitHub

@christophstrobl is already working on this.

Since May 25, 2022.

type: task
Dominant language
Java
Stars
1.7k
Forks
1.1k
No merged PRs in 30d

Description

Asserting that eg. a property name must not be empty can be quite expensive if done frequently esp. within the mapping layer.
Also remove assertions done multiple times for the same input.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.