spring-projects / spring-projects/spring-data-mongodb
repository insert collection method call findOne of all items if @Id annotated field is valorized
Open
@christophstrobl is already working on this.
Since Jan 17, 2022.
status: waiting-for-triage
type: documentation
- Dominant language
- Java
- Stars
- 1.7k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
Java doc of repository insert collection method say :
"Inserts the given entities. Assumes the given entities to have not been persisted yet and thus will optimize the insert over a call to saveAll(Iterable). Prefer using saveAll(Iterable) to avoid the usage of storespecific API."
but if @Id annotated fields of items in collection are pre valorized, repository first check all id and after this, save data but this degrade the performance of a code like this:
repository.deleteAll();
repository.insert(collection);
is this behavior intentional?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.