spring-projects / spring-projects/spring-data-mongodb

Add support for CriteriaDefinition on $or operator

Open
#3,895 3 comments 2 reactions 1 assignee View on GitHub

@christophstrobl is already working on this.

Since Dec 6, 2021.

status: ideal-for-contribution type: enhancement
Dominant language
Java
Stars
1.7k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Currently in Criteria class we have the method

public Criteria orOperator(Criteria... criteria) {
		BasicDBList bsonList = createCriteriaList(criteria);
		return registerCriteriaChainElement(new Criteria("$or").is(bsonList));
	}

This can be changed to

public Criteria orOperator(CriteriaDefinition... criteria) {
		BasicDBList bsonList = createCriteriaList(criteria);
		return registerCriteriaChainElement(new Criteria("$or").is(bsonList));
	}

In this case it will be more flexible, and also it will be possible to have Criteria and TextCriteria mixed in $or operator.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.