spring-projects / spring-projects/spring-data-mongodb
Update AggregationTests.filterShouldBeAppliedCorrectly to use non-deprecated method [DATAMONGO-1606]
Open
@odrotbohm is already working on this.
Since Dec 30, 2020.
type: enhancement
- Dominant language
- Java
- Stars
- 1.7k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
Amy Aldredge opened DATAMONGO-1606 and commented
Trying to figure out the correct syntax for aggregation framework project filter using AggregationExpression over the deprecated AggregationFunctionExpressions is difficult without an example.
The following seems to be the correct syntax to do the equivalent operation (line 1503/1504)
TypedAggregation<Sales> agg = newAggregation(Sales.class, project().and("items")
.filter("item", ComparisonOperators.Gte.valueOf("item.price").greaterThanEqualToValue(100)).as("items"));
Affects: 1.10 GA (Ingalls)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.