spring-projects / spring-projects/spring-data-mongodb

When reading a persisted document @Nullable annotations should be handled [DATAMONGO-1160]

Open
#2,078 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 30, 2020.

in: mapping type: enhancement
Dominant language
Java
Stars
1.7k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Christian Schneider opened DATAMONGO-1160 and commented

The MongoDB Mapper should read @Nullable Annotations on constructors.

The attached example shows our need to add an dedicated @PersistanceConstructor.
The author tried to put an @Nullable but he still got an exception.
In our case the Throwable cause argument is transient.

The same should be possible with Optionals.

To clarify: My actual concern with this ticket is that we don't like to add an own constructor when using @transient to make the spring-data-mapping work


Affects: 1.6.2 (Evans SR2)

Attachments:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.