spring-projects / spring-projects/spring-data-couchbase
CouchbaseRepositoryQueryIntegrationTests.testExpiration broken after fixing ThreadLocal storage with save()
Open
@mikereiche is already working on this.
Since Jan 15, 2024.
type: regression
- Dominant language
- Java
- Stars
- 284
- Forks
- 197
- PR merge metrics
- No merged PRs in 30d
Description
CouchbaseRepositoryQueryIntegrationTests.testExpiration:759 expected: not equal but was: <0>a
It's because Options are now discarded on save()
public void testExpiration() {
Airport airport = new Airport("1", "iata21", "icao21");
airportRepository.withOptions(InsertOptions.insertOptions().expiry(Duration.ofSeconds(10))).save(airport);
Airport foundAirport = airportRepository.findByIata(airport.getIata());
assertNotEquals(0, foundAirport.getExpiration());
airportRepository.delete(airport);
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.