spring-projects / spring-projects/spring-data-couchbase
query.with(pageable) and query.with(sort) are not with-ers (immutable)
Open
Nobody has claimed this yet.
type: enhancement
- Dominant language
- Java
- Stars
- 284
- Forks
- 197
- PR merge metrics
- No merged PRs in 30d
Description
query.with(pageable) and query.with(sort) are not with-ers (immutable) and therefore should be renamed query.pageable(pageable) and query.sort(Sort).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Query API definitions and all call sites for query.with(pageable) and query.with(sort). Review related tests before changing the method names to query.pageable(pageable) and query.sort(Sort). Done means the renamed API is used consistently and the relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend, databases
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100