spring-projects / spring-projects/spring-data-couchbase
Support returning any deleted entities in ReactiveRemoveByIdOperation and ReactiveRemoveByQueryOperation
Open
@mikereiche is already working on this.
Since Mar 24, 2021.
status: blocked
type: enhancement
- Dominant language
- Java
- Stars
- 284
- Forks
- 197
- PR merge metrics
- No merged PRs in 30d
Description
This should work alongside cas support in PR #1051
Idea for API:
MyEntity entity = template.removeById(MyEntity.class)
.withCas(12345L)
.one("abc123");
It would be good if this support was also extended to org.springframework.data.couchbase.repository.CouchbaseRepository
Right now we have a custom base repository exposing delete methods that return the deleted document.
Having this in the base implementation would reduce the surface area of our custom base repository and I suspect be helpful to others too.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.