spring-projects / spring-projects/spring-data-commons
Improve design in repository configuration area regarding component scanning [DATACMNS-493]
@odrotbohm is already working on this.
Since Dec 30, 2020.
- Dominant language
- Java
- Stars
- 838
- Forks
- 730
- PR merge metrics
- No merged PRs in 30d
Description
Oliver Drotbohm opened DATACMNS-493 and commented
In the course of fixing DATACMNS-492 it became clear that currently the implementation of scanning for repository components is spread amongst two separate places (the RepositoryConfigurationSourceSupport - repository interfaces - as well as the RepositoryBeanDefinitionBuilder - for custom implementations).
This requires both the ResourceLoader and the Environment to be handed into both components. This should be unified into a single place by either moving the scanning for custom implementations into RepositoryConfigurationSourceSupport as well or by moving the entire scanning into RepositoryBeanDefinitionBuilder
Issue Links:
- DATACMNS-492 Scanning for custom repository implementation classes does not use Environment
Referenced from: commits https://github.com/spring-projects/spring-data-commons/commit/ec49499e50ea3a282ed2031a467c5b02189ad130, https://github.com/spring-projects/spring-data-commons/commit/3e4e9c2b2c6f88403b1e2bc9032b1578a588bc43
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.