spring-projects / spring-projects/spring-data-commons

AnnotationBasedPersistentProperty cannot resolve Id properties [Wrong Id class used]

Open
#3,283 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: feedback-provided status: waiting-for-triage
Dominant language
Java
Stars
838
Forks
730
PR merge metrics
No merged PRs in 30d

Description

BasicPersistentEntity::returnPropertyIfBetterIdPropertyCandidateOrNull
--> AnnotationBasedPersistentProperty::isIdProperty

https://github.com/spring-projects/spring-data-commons/blob/main/src/main/java/org/springframework/data/mapping/model/AnnotationBasedPersistentProperty.java#L78-L79

Shouldn't the Id.class used here be jakarta.persistence.id?

Otherwise the RelationalEntityMetadata doesn't contain the id column.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/main/java/org/springframework/data/mapping/model/AnnotationBasedPersistentProperty.java at the referenced lines and trace how BasicPersistentEntity selects an id property. Check how this affects RelationalEntityMetadata and its id column. Done means the appropriate Id annotation is recognized and the relational metadata contains the id column.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.