spring-projects / spring-projects/spring-data-commons

Apply Kotlin Value Class unboxing for repository invocations

Open
#2,868 7 comments 8 reactions 1 assignee View on GitHub

@mp911de is already working on this.

Since Jun 28, 2023.

in: kotlin type: enhancement
Dominant language
Java
Stars
838
Forks
730
PR merge metrics
No merged PRs in 30d

Description

When defining a value class as Id type ( MyRepository : Repository<MyEntity, MyValueClass>), calls that pass on Value class instances must apply wrapping/unwrapping according to the rules of how Kotlin expands Value class types.

It would be great to have an interceptor that translates arguments for findById(ID) calls, essentially all methods that accept ID.

See also spring-projects/spring-data-jpa#2840

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.