spring-projects / spring-projects/spring-data-commons

PagedResourceAssembler does not provide option to use InaLinkRelations.PREVIOUS over InaLinkRelations.PREV

Open
#2,740 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 12, 2022.

status: waiting-for-triage
Dominant language
Java
Stars
838
Forks
730
PR merge metrics
No merged PRs in 30d

Description

This is related to following code snippet

private <R> PagedModel<R> addPaginationLinks(PagedModel<R> resources, Page<?> page, Optional<Link> link) {

		UriTemplate base = getUriTemplate(link);

		boolean isNavigable = page.hasPrevious() || page.hasNext();

		if (isNavigable || forceFirstAndLastRels) {
			resources.add(createLink(base, PageRequest.of(0, page.getSize(), page.getSort()), IanaLinkRelations.FIRST));
		}

		if (page.hasPrevious()) {
			resources.add(createLink(base, page.previousPageable(), IanaLinkRelations.PREV));
		}

If one wants to prefer "previous" over "prev" in link relation parameter name, It is impossible to configure it,
for now I am modifying the generated link and replacing "prev" with "previous",
can this be improved?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.