spring-projects / spring-projects/spring-data-commons
Remove use of star imports in the codebase
Open
Nobody has claimed this yet.
for: team-attention
type: task
- Dominant language
- Java
- Stars
- 838
- Forks
- 730
- PR merge metrics
- No merged PRs in 30d
Description
A number of production classes and test classes alike import all the members of a class using a star import or static star import.
Star imports do not improve the readability of a class, and often times introduces ambiguity (confusion) when more than one class shares a similar API (e.g. by name).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the production and test classes in the repository for regular star imports and static star imports. Replace each with explicit member imports, then verify that no star imports remain and run the relevant project checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100