spring-projects / spring-projects/spring-data-commons

Fix dependency direction between repository.query and repository.query.parser [DATACMNS-1686]

Open
#2,108 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 30, 2020.

in: core type: task
Dominant language
Java
Stars
838
Forks
730
No merged PRs in 30d

Description

Oliver Drotbohm opened DATACMNS-1686 and commented

o.s.d.repository.query.parser.AbstractQueryCreator creates a dependency towards types in o.s.d.repository.query which causes all additional functionality referring to both tickets having to live in the parser package. There's no real reason for AQC to live in the parser package. For 3.0 we should:

  • move the class to o.s.d.repository.query
  • move functionality from PartTreeJpaQuery to the Parameters type hierarchy

No further details from DATACMNS-1686

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.