spring-projects / spring-projects/spring-data-commons

Clean up registration of repositories involving classloading checks on registration [DATACMNS-1619]

Open
#2,011 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 30, 2020.

in: repository type: enhancement
Dominant language
Java
Stars
838
Forks
730
PR merge metrics
No merged PRs in 30d

Description

Oliver Drotbohm opened DATACMNS-1619 and commented

DATACMNS-1617 unveiled that we apparently inadvertently keep repository interfaces that cannot even be loaded around for inspection (see RepositoryConfigurationExtensionSupport.getRepositoryConfigurations(…) and {….loadRepositoryInterface(…)}}). They effectively cannot be used and will cause errors downstream upon closer inspection, which is probably one reason that the error has not been discovered yet.

Apart from avoiding to keep those around in the initial configuration phase, it creates the impression, we'd adapt to classpath errors in the configuration which we don't do and don't want to


Issue Links:

  • DATACMNS-1617 Automatically drop repository interfaces that cannot be loaded fully

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.