spring-projects / spring-projects/spring-data-commons
Allow customization of ConversionService in RepositoryFactorySupport [DATACMNS-1512]
@mp911de is already working on this.
Since Dec 30, 2020.
- Dominant language
- Java
- Stars
- 838
- Forks
- 730
- PR merge metrics
- No merged PRs in 30d
Description
wreulicke opened DATACMNS-1512 and commented
We have library using spring-data-commons, https://github.com/dai0304/spring-data-mirage.
I would like to use custom collection.
public interface Chunk<T> extends Collection<T> {
Stream<T> stream();
// and etc...
}
And Repository using custom collection is below.
public interface ChunkableRepository<E, ID extends Serializable>extends ReadableRepository<E, ID> {
Chunk<E> findAll();
}
In 2.0.9.RELEASE, it works.
but, in 2.1.6.RELEASE, it does not work due to DATACMNS-1482, since element type conversion introduced.
Also, we cannot customize conversionService of QueryExecutionResultHandler.
Ref:
- QueryExecutionResultHandler 2.0.9
- QueryExecutionResultHandler 2.1.6
- QueryExecutionResultHandler master
Referenced from: pull request https://github.com/spring-projects/spring-data-commons/pull/391
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.