spring-projects / spring-projects/spring-data-commons

Allow customization of ConversionService in RepositoryFactorySupport [DATACMNS-1512]

Open
#1,943 2 comments 0 reactions 1 assignee View on GitHub

@mp911de is already working on this.

Since Dec 30, 2020.

type: enhancement
Dominant language
Java
Stars
838
Forks
730
PR merge metrics
No merged PRs in 30d

Description

wreulicke opened DATACMNS-1512 and commented

We have library using spring-data-commons, https://github.com/dai0304/spring-data-mirage. 

 

I would like to use custom collection.

public interface Chunk<T> extends Collection<T> {
  Stream<T> stream();
  // and etc...
}

 

And Repository using custom collection is below.

public interface ChunkableRepository<E, ID extends Serializable>extends ReadableRepository<E, ID> {
    Chunk<E> findAll();
}

 

In 2.0.9.RELEASE, it works.

but, in 2.1.6.RELEASE, it does not work due to DATACMNS-1482, since element type conversion introduced.

Also, we cannot customize conversionService of QueryExecutionResultHandler.

Ref: 


Referenced from: pull request https://github.com/spring-projects/spring-data-commons/pull/391

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.