spring-projects / spring-projects/spring-data-commons

Add flags to register pageable/sort resolvers on @EnableSpringDataWebSupport [DATACMNS-1494]

Open
#1,929 3 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 30, 2020.

status: declined
Dominant language
Java
Stars
838
Forks
730
PR merge metrics
No merged PRs in 30d

Description

Tadaya Tsuyukubo opened DATACMNS-1494 and commented

I would like to have flags to control registering default pageable and sort resolvers on @EnableSpringDataWebSupport.

In my use case, I register a resolver for Pageable which collide with the default resolver registered by SpringDataWebConfiguration.

DATACMNS-822 introduced customizers but that still registers default resolvers.

In DATACMNS-1016, there is a comment saying extend the configuration class and "@Import" it instead of using _@EnableSpringDataWebSupport_.
That for sure works, but requires an extended class and use "@Import" instead of "@Enabled..."

Since adding that control in @EnableSpringDataWebSupport is more intuitive from user perspective, I want "registerPageableResolver" and "registerSortResolver" flags to be added on @EnableSpringDataWebSupport.

PR will follow


No further details from DATACMNS-1494

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.