spring-projects / spring-projects/spring-data-commons

Make the ConversionsService used in ProjectingMethodInterceptor configurable [DATACMNS-1452]

Open
#1,882 0 comments 0 reactions 1 assignee View on GitHub

@odrotbohm is already working on this.

Since Dec 30, 2020.

type: enhancement
Dominant language
Java
Stars
838
Forks
730
PR merge metrics
No merged PRs in 30d

Description

Jens Schauder opened DATACMNS-1452 and commented

The ProjectingMethodInterceptor currently get it's ConversionService from the ProxyProjectionFactory that creates it and that always uses the DefaultConversionService.getSharedInstance().

This causes DATAJPA-1482 where a projection fails because on attribute needs a conversion in that case from Timestamp to LocalDate without a reasonable way to register such a conversion.

There should be a way to register custom conversions.
Preferably these should be kept in sync with CustomConversions as used in SD-Mong, SD-JDBC and SD-R2DBC


Issue Links:

  • DATAJPA-1482 Issue with interface projection for a native postgres query
    ("is depended on by")

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.