spring-projects / spring-projects/spring-data-commons
Registration of custom converters [DATACMNS-1307]
@mp911de is already working on this.
Since Dec 30, 2020.
- Dominant language
- Java
- Stars
- 838
- Forks
- 730
- PR merge metrics
- No merged PRs in 30d
Description
James Green opened DATACMNS-1307 and commented
Apologies if this is already recorded but I would have saved a lot of time from #820 if I had not needed to implement a custom redisCustomConversions and instead been able to inject this with my code and added to it at run-time.
I spotted the @ReadingConverter annotation and without reading any further expected this to be scanned for and included. Then, realised no such magic occurred and still further realised there was no redisCustomConversions for autowiring (according to IntelliJ, at least) and thus a full bean override was needed.
The JMS integration works with a bunch of message converters, perhaps the Redis side could adopt the same or use this as the basis?
No further details from DATACMNS-1307
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.